Update test suite to future-proof base images#299
Merged
WyriHaximus merged 1 commit intoreactphp:1.xfrom Oct 15, 2022
Merged
Conversation
WyriHaximus
reviewed
Oct 10, 2022
Member
Author
|
Updated to work around failing test case for legacy HHVM (trying to allocate 1048576 file descriptors turns out to be a bad idea). This is now ready for review |
a8cf6ac to
73db2a9
Compare
Member
Author
|
I've just updated this to use |
This was referenced Oct 12, 2022
SimonFrings
approved these changes
Oct 13, 2022
WyriHaximus
approved these changes
Oct 15, 2022
Member
WyriHaximus
left a comment
There was a problem hiding this comment.
Thanks for the updates, looks even better now 👍 .
This was referenced Oct 19, 2022
This was referenced Oct 26, 2022
This was referenced Oct 30, 2022
This was referenced Nov 13, 2022
This was referenced Jan 30, 2023
This was referenced Feb 21, 2023
This was referenced Mar 2, 2023
This was referenced Nov 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple changeset updates the test suite to future-proof base images. Likewise, legacy HHVM is now executed in an up-to-date base image, but using a legacy container instead. This way, we no longer depend on any legacy base images that will be removed in the future as per https://github.blog/changelog/2022-08-09-github-actions-ubuntu-22-04-is-now-generally-available-on-github-hosted-runners/, https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/ and actions/runner-images#6002. I've confirmed pulling container images from Docker Hub does not appear to be rate-limited as per actions/runner-images#1445. Once these changes are merged, we should apply similar updates to all our other components.
Builds on top of #297 and #289